Skip to content

gh-94801: Fix regression in configure's CPPFLAGS handling (GH-95288) #95288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2022
Merged

gh-94801: Fix regression in configure's CPPFLAGS handling (GH-95288) #95288

merged 1 commit into from
Jul 26, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Jul 26, 2022 •
edited by bedevere-bot
Loading

@tiran tiran added build The build process and cross-build release-blocker needs backport to 3.11 only security fixes labels Jul 26, 2022
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 26, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @tiran for commit 15a5d94 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 26, 2022
@tiran
Copy link
Member Author

tiran commented Jul 26, 2022 •
edited
Loading

Failing build https://buildbot.python.org/all/#/builders/1046/builds/278 is fixed by #95296

@tiran tiran changed the title gh-94801: Fix regression in configure's CPPFLAGS handling gh-94801: Fix regression in configure's CPPFLAGS handling (GH-95288) Jul 26, 2022
@tiran tiran merged commit 9af7f87 into python:main Jul 26, 2022
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@tiran tiran deleted the gh-94801-fix-cppflags branch July 26, 2022 19:39
@miss-islington
Copy link
Contributor

Sorry, @tiran, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9af7f87d763ed6e1c5f56ae40d8242ab22866b33 3.11

tiran added a commit to tiran/cpython that referenced this pull request Jul 26, 2022
@tiran
[3.11] pythongh-94801: Fix regression in configure's CPPFLAGS handling (
9526b00 
pythonGH-95288).

(cherry picked from commit 9af7f87)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot
Copy link

GH-95297 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 26, 2022
ambv pushed a commit that referenced this pull request Jul 27, 2022
@tiran
[3.11] gh-94801: Fix regression in configure's CPPFLAGS handling (GH-…
c72c1d6 
…95288) (GH-95297)

(cherry picked from commit 9af7f87)

Co-authored-by: Christian Heimes <christian@python.org>
@zanieb zanieb mentioned this pull request Dec 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees

@tiran tiran

Labels
build The build process and cross-build release-blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tiran @bedevere-bot @miss-islington @pablogsal @erlend-aasland