Skip to content

gh-95471: IDLE - Tweak Edit menu #95481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 31, 2022
Merged

Conversation

terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented Jul 30, 2022

Move Select All above Cut as it is used with Cut and Copy
but not Paste. Add a separator between Replace and
Go to Line to show IDLE issue triagers the separation between
'Edit-find' and 'Edit-show' topics.

Move `Select All` above  `Cut` as it is used with `Cut` and `Copy`
but not `Paste`.  Add a separator between `Replace` and
`Go to Line` to show IDLE issue triagers the separation between
'Edit-find' and 'Edit-show' topics.
@terryjreedy
Copy link
Member Author

@erlend-aasland Do you think the blurb is too wordy? If so, the last two sentences could be

Move ``Select All`` and add a new separator.

@terryjreedy terryjreedy added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jul 30, 2022
@erlend-aasland
Copy link
Contributor

@erlend-aasland Do you think the blurb is too wordy? If so, the last two sentences could be

Move ``Select All`` and add a new separator.

IMHO, yes. The changelog is huge; keeping each item succinct is nice. Maybe prefix with Edit menu: or In Edit menu,?

@terryjreedy
Copy link
Member Author

Good point. Unlike NEWS.txt, blurbs have a direct link to the issue. In this case, I copied the expanded text from the initial issue message. We can now edit such when an issue is closed to give a good summary for anyone visiting.

@terryjreedy terryjreedy merged commit 53357b3 into python:main Jul 31, 2022
@miss-islington
Copy link
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-95487 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 31, 2022
@bedevere-bot
Copy link

GH-95488 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 31, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 31, 2022
Move `Select All` above  `Cut` as it is used with `Cut` and `Copy` but not `Paste`.  Add a separator between `Replace` and `Go to Line` to separate items that belong to the 'Edit-find' (above) and 'Edit-show' (below) IDLE github project topics.
(cherry picked from commit 53357b3)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 31, 2022
Move `Select All` above  `Cut` as it is used with `Cut` and `Copy` but not `Paste`.  Add a separator between `Replace` and `Go to Line` to separate items that belong to the 'Edit-find' (above) and 'Edit-show' (below) IDLE github project topics.
(cherry picked from commit 53357b3)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@terryjreedy terryjreedy deleted the editmenu branch July 31, 2022 01:10
miss-islington added a commit that referenced this pull request Jul 31, 2022
Move `Select All` above  `Cut` as it is used with `Cut` and `Copy` but not `Paste`.  Add a separator between `Replace` and `Go to Line` to separate items that belong to the 'Edit-find' (above) and 'Edit-show' (below) IDLE github project topics.
(cherry picked from commit 53357b3)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington added a commit that referenced this pull request Jul 31, 2022
Move `Select All` above  `Cut` as it is used with `Cut` and `Copy` but not `Paste`.  Add a separator between `Replace` and `Go to Line` to separate items that belong to the 'Edit-find' (above) and 'Edit-show' (below) IDLE github project topics.
(cherry picked from commit 53357b3)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants