python · silane · Sep 25, 2018 · Sep 26, 2018 · Sep 26, 2018 · Sep 26, 2018
@@ -131,6 +131,8 @@ def _finalize_set(msg, disposition, filename, cid, params):
 # drop both this and quoprimime.body_encode in favor of enhanced binascii
 # routines that accepted a max_line_length parameter.
 def _encode_base64(data, max_line_length):
+    if not max_line_length:
+        return binascii.b2a_base64(data).decode('ascii')
     encoded_lines = []
     unencoded_bytes_per_line = max_line_length // 4 * 3
     for i in range(0, len(data), unencoded_bytes_per_line):
@@ -150,8 +152,8 @@ def normal_body(lines): return b'\n'.join(lines) + b'\n'
             return '7bit', normal_body(lines).decode('ascii')
         except UnicodeDecodeError:
             pass
-        if (policy.cte_type == '8bit' and
-                max(len(x) for x in lines) <= policy.max_line_length):
+        if (policy.cte_type == '8bit' and (not policy.max_line_length or
+                max(len(x) for x in lines) <= policy.max_line_length)):
             return '8bit', normal_body(lines).decode('ascii', 'surrogateescape')
         sniff = embedded_body(lines[:10])
         sniff_qp = quoprimime.body_encode(sniff.decode('latin-1'),

@@ -168,6 +168,8 @@ def body_encode(body, maxlinelen=76, eol=NL):
 
     """
 
+    if not maxlinelen:
+        maxlinelen=float('+inf')
     if maxlinelen < 4:
         raise ValueError("maxlinelen must be at least 4")
     if not body:

@@ -453,6 +453,45 @@ def test_set_text_11_lines_long_line_maximal_non_ascii_heuristics(self):
         self.assertEqual(m.get_payload(decode=True).decode('utf-8'), content)
         self.assertEqual(m.get_content(), content)
 
+    def test_set_text_non_ascii_with_policy_max_line_length_none_or_0(self):
+        for max_line_length in (0, None):
+            with self.subTest(max_line_length=max_line_length):
+                policy = self.policy.clone(max_line_length=max_line_length)
+                m = self.message(policy=policy)
+                content = ("áàäéèęöőáàäéèęöőáàäéèęöőáàäéèęöő"
+                        "áàäéèęöőáàäéèęöőáàäéèęöőáàäéèęöő"
+                        "áàäéèęöőáàäéèęöőáàäéèęöőáàäéèęöő.\n")
+                raw_data_manager.set_content(m, content)
+                self.assertEqual(bytes(m), (textwrap.dedent("""\
+                    Content-Type: text/plain; charset="utf-8"
+                    Content-Transfer-Encoding: 8bit
+                    """) + "\n" + \
+                    "áàäéèęöőáàäéèęöőáàäéèęöőáàäéèęöő"
+                    "áàäéèęöőáàäéèęöőáàäéèęöőáàäéèęöő"
+                    "áàäéèęöőáàäéèęöőáàäéèęöőáàäéèęöő.\n"
+                    ).encode('utf8'))
+                self.assertEqual(
+                    m.get_payload(decode=True).decode('utf-8'), content)
+                self.assertEqual(m.get_content(), content)
+
+    def test_set_bytes_with_policy_max_line_length_none_or_0(self):
+        for max_line_length in (0, None):
+            with self.subTest(max_line_length=max_line_length):
+                policy = self.policy.clone(max_line_length=max_line_length)
+                m = self.message(policy=policy)
+                content = b'b\xFFgus\tcon\nt\rent ' + b'z'*80
+                raw_data_manager.set_content(
+                    m, content, maintype='application', subtype='octet-stream')
+                self.assertEqual(bytes(m), textwrap.dedent("""\
+                    Content-Type: application/octet-stream
+                    Content-Transfer-Encoding: base64
+                    """).encode('ascii') + b"\n" +
+                    b"Yv9ndXMJY29uCnQNZW50IHp6enp6enp6enp6enp6enp6enp6enp6enp6"
+                    b"enp6enp6enp6enp6enp6enp6enp6enp6enp6enp6enp6enp6enp6enp6"
+                    b"enp6enp6enp6enp6\n")
+                self.assertEqual(m.get_payload(decode=True), content)
+                self.assertEqual(m.get_content(), content)
+
     def test_set_text_non_ascii_with_cte_7bit_raises(self):
         m = self._make_message()
         with self.assertRaises(UnicodeError):

diff --git a/Misc/NEWS.d/next/Library/2018-09-26-15-18-18.bpo-34800.auD5YK.rst b/Misc/NEWS.d/next/Library/2018-09-26-15-18-18.bpo-34800.auD5YK.rst
@@ -0,0 +1,2 @@
+Fix `email.contentmanager.set_content` raise error when
+`email.policy.Policy.max_line_length` is 0 or None. Patch by silane.
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		Fix `email.contentmanager.set_content` raise error when
Copy link Contributor maxking May 28, 2019 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Some small suggestions: Fixed a bug where ``email.contentmanager.set_content`` raised error when ``email.policy.Policy.max_line_length`` is 0 or ``None``. Patch by silane. In rst, `<code>` sections needs to be wrapped in double backticks.
		`email.policy.Policy.max_line_length` is 0 or None. Patch by silane.