GH-96073: Fix wild replacement in formatannotation #96074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iyume
commented
Aug 18, 2022
•
- Issue: Lib/inspect.py: Avoid wild replacement in formatannotation #96073
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
sobolevn
reviewed
Aug 29, 2022
There was a problem hiding this comment.
Please, don't forget to add news and tests.
I also think that proposed solution can be simplified?
I propose adding a new module to test it, something like:
new file: Lib/test/typingdata/__init__.py
new file: Lib/test/typingdata/typing.py
In the future we can even more all ann_modules there 🤔
|
@sobolevn I have added some test based on your suggestion. |
Misc/NEWS.d/next/Library/2022-08-29-12-35-28.gh-issue-96073.WaGstf.rst
Outdated
Show resolved
Hide resolved
…Gstf.rst Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
sobolevn
reviewed
Aug 31, 2022
JelleZijlstra
approved these changes
Oct 7, 2022
|
Thanks @iyume for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-98045 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 7, 2022
…honGH-96074) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> (cherry picked from commit d5fea01) Co-authored-by: Anh71me <iyumelive@gmail.com>
|
GH-98046 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 7, 2022
…honGH-96074) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> (cherry picked from commit d5fea01) Co-authored-by: Anh71me <iyumelive@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Oct 7, 2022
miss-islington
added a commit
that referenced
this pull request
Oct 7, 2022
mpage
pushed a commit
to mpage/cpython
that referenced
this pull request
Oct 11, 2022
…hon#96074) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.