Skip to content

gh-96175: add missing self._localName assignment in xml.dom.minidom.Attr #96176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 23, 2022
Merged

gh-96175: add missing self._localName assignment in xml.dom.minidom.Attr #96176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9cb30d5
Fix: add missing self._localName assignment in `xml.dom.minidom.Attr`
kkirsche Aug 22, 2022
70a82e1
fix: add missing unit test
Aug 22, 2022
c97a7fa
fix: add missing import
Aug 22, 2022
fb8c871
fix: add blurb
Aug 22, 2022
d2eec57
fix: use of default role in rst
Aug 22, 2022
fcbe67a
Use requested NEWS format
kkirsche Aug 23, 2022
dee21ce
fix: remove undesired unit test error messages
Aug 23, 2022
8910ca9
use Jelles preferred testing style
Aug 23, 2022
19fbcc4
refactor: update tests to verify that _get_name falls back to qName
Aug 23, 2022
93e41d1
Merge branch 'main' into patch-2
kkirsche Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion Lib/test/test_minidom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import pyexpat
import xml.dom.minidom

from xml.dom.minidom import parse, Node, Document, parseString
from xml.dom.minidom import parse, Attr, Node, Document, parseString
from xml.dom.minidom import getDOMImplementation
from xml.parsers.expat import ExpatError

Expand Down Expand Up @@ -77,6 +77,20 @@ def testParseFromTextFile(self):
dom.unlink()
self.confirm(isinstance(dom, Document))

def testAttrModeSetsParamsAsAttrs(self):
attr = Attr("qName", "namespaceURI", "localName", "prefix")
self.assertEqual(attr.name, "qName")
self.assertEqual(attr.namespaceURI, "namespaceURI")
self.assertEqual(attr.prefix, "prefix")
self.assertEqual(attr.localName, "localName")

def testAttrModeSetsNonOptionalAttrs(self):
attr = Attr("qName", "namespaceURI", None, "prefix")
self.assertEqual(attr.name, "qName")
self.assertEqual(attr.namespaceURI, "namespaceURI")
self.assertEqual(attr.prefix, "prefix")
self.assertEqual(attr.localName, attr.name)

def testGetElementsByTagName(self):
dom = parse(tstfile)
self.confirm(dom.getElementsByTagName("LI") == \
Expand Down
2 changes: 2 additions & 0 deletions Lib/xml/dom/minidom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,8 @@ def __init__(self, qName, namespaceURI=EMPTY_NAMESPACE, localName=None,
self._name = qName
self.namespaceURI = namespaceURI
self._prefix = prefix
if localName is not None:
self._localName = localName
self.childNodes = NodeList()

# Add the single child node that represents the value of the attr
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2022-08-22-13-54-20.gh-issue-96175.bH7zGU.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix unused ``localName`` parameter in the ``Attr`` class in :mod:`xml.dom.minidom`.