Skip to content

gh-95432: Add doctest for sqlite3 tutorial #96193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2022
Merged

gh-95432: Add doctest for sqlite3 tutorial #96193

merged 1 commit into from
Aug 23, 2022
+47 −16

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Aug 22, 2022 •
edited by bedevere-bot
Loading

@erlend-aasland erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.10 only security fixes labels Aug 22, 2022
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news awaiting core review labels Aug 22, 2022
CAM-Gerlach
CAM-Gerlach reviewed Aug 23, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems LGTM, aside from one concern, though to be honest my knowledge of doctests is mostly limited to skimming the Sphinx docs on them

@erlend-aasland erlend-aasland merged commit 04c73e5 into python:main Aug 23, 2022
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@erlend-aasland
Copy link
Contributor Author

Thanks for the review, CAM!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 23, 2022
@erlend-aasland @miss-islington
pythongh-95432: Add doctest for sqlite3 tutorial (pythonGH-96193)
bb12edc 
(cherry picked from commit 04c73e5)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@erlend-aasland erlend-aasland deleted the sqlite-doctest branch August 23, 2022 06:48
@bedevere-bot
Copy link

GH-96200 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 23, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 23, 2022
@erlend-aasland @miss-islington
pythongh-95432: Add doctest for sqlite3 tutorial (pythonGH-96193)
12e82f7 
(cherry picked from commit 04c73e5)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

GH-96201 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 23, 2022
miss-islington added a commit that referenced this pull request Aug 23, 2022
@miss-islington @erlend-aasland
gh-95432: Add doctest for sqlite3 tutorial (GH-96193)
88a559f 
(cherry picked from commit 04c73e5)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
miss-islington added a commit that referenced this pull request Aug 23, 2022
@miss-islington @erlend-aasland
gh-95432: Add doctest for sqlite3 tutorial (GH-96193)
145d8f0 
(cherry picked from commit 04c73e5)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@erlend-aasland erlend-aasland mentioned this pull request Aug 24, 2022
Merged
mdboom pushed a commit to mdboom/cpython that referenced this pull request Aug 24, 2022
@erlend-aasland @mdboom
pythongh-95432: Add doctest for sqlite3 tutorial (python#96193)
a9d5f6b
@erlend-aasland erlend-aasland linked an issue Aug 29, 2022 that may be closed by this pull request
Make sure all sqlite3 doc examples work #95432
Closed
@erlend-aasland erlend-aasland mentioned this pull request Aug 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach left review comments

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

@hugovk hugovk Awaiting requested review from hugovk

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make sure all sqlite3 doc examples work
4 participants
@erlend-aasland @miss-islington @bedevere-bot @CAM-Gerlach