gh-80678: Add comment on preferred csv delimiters #96199
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eendebakpt
reviewed
Oct 22, 2022
| @@ -275,6 +275,8 @@ The :mod:`csv` module defines the following classes: | |||
| reflecting the parameters found. If the optional *delimiters* parameter | |||
| is given, it is interpreted as a string containing possible valid | |||
| delimiter characters. | |||
| If not excluded by the *delimiters* parameter, and if there is ambiguity, | |||
There was a problem hiding this comment.
Why is the documentation here not added to the def sniff docstring? That would be a natural place for documentation that is available from the command line or IDE.
There was a problem hiding this comment.
I'm not sure what information should go into the docstring vs in the docs. I imagine there's some duplicate, but surely not everything in the docs goes into the docstring and vice-versa. The docstring of sniff is looking a bit empty though, so it could use some work for sure.
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
|
The following commit authors need to sign the Contributor License Agreement: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.python.org/dev/library/csv.html#csv.Sniffer.sniff
See
cpython/Lib/csv.py
Line 177 in 1499d73
cpython/Lib/csv.py
Lines 369 to 375 in 1499d73