Skip to content

GH-96172 fix unicodedata.east_asian_width being wrong on unassigned code points #96207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 26, 2022
Merged

GH-96172 fix unicodedata.east_asian_width being wrong on unassigned code points #96207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5688e6a
GH-96172 unicodedata: fix wrong default for east_asian_width
cfbolz Aug 23, 2022
5802448
add news entry
cfbolz Aug 23, 2022
5f37da7
add east_asian_width to the checksum test
cfbolz Aug 23, 2022
cb8b433
add comment, link to the standard, add explicit test for the changes
cfbolz Aug 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion Lib/test/test_unicodedata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ class UnicodeFunctionsTest(UnicodeDatabaseTest):

# Update this if the database changes. Make sure to do a full rebuild
# (e.g. 'make distclean && make') to get the correct checksum.
expectedchecksum = '98d602e1f69d5c5bb8a5910c40bbbad4e18e8370'
expectedchecksum = '4975f3ec0acd4a62465d18c9bf8519b1964181f6'

@requires_resource('cpu')
def test_function_checksum(self):
Expand All @@ -90,6 +90,7 @@ def test_function_checksum(self):
self.db.decomposition(char),
str(self.db.mirrored(char)),
str(self.db.combining(char)),
unicodedata.east_asian_width(char),
]
h.update(''.join(data).encode("ascii"))
result = h.hexdigest()
Expand Down Expand Up @@ -220,6 +221,23 @@ def test_east_asian_width(self):
self.assertEqual(eaw('\u2010'), 'A')
self.assertEqual(eaw('\U00020000'), 'W')

def test_east_asian_width_unassigned(self):
eaw = self.db.east_asian_width
# unassigned
for char in '\u0530\u0ece\u10c6\u20fc\uaaca\U000107bd\U000115f2':
self.assertEqual(eaw(char), 'N')
self.assertIs(self.db.name(char, None), None)

# unassigned but reserved for CJK
for char in '\uFA6E\uFADA\U0002A6E0\U0002FA20\U0003134B\U0003FFFD':
self.assertEqual(eaw(char), 'W')
self.assertIs(self.db.name(char, None), None)

# private use areas
for char in '\uE000\uF800\U000F0000\U000FFFEE\U00100000\U0010FFF0':
self.assertEqual(eaw(char), 'A')
self.assertIs(self.db.name(char, None), None)

def test_east_asian_width_9_0_changes(self):
self.assertEqual(self.db.ucd_3_2_0.east_asian_width('\u231a'), 'N')
self.assertEqual(self.db.east_asian_width('\u231a'), 'W')
Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2022-08-23-13-30-30.gh-issue-96172.7WTHer.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix a bug in ``unicodedata``: ``east_asian_width`` used to return the wrong
value for unassigned characters; and for yet unassigned, but reserved
characters.
Loading