gh-94781: Clean previous instances of ouput files on Windows #96423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ython\frozen_modules` directories.
|
As far as I can tell, this looks good; nice job! It should get an approval from someone with fresher MSBuild experience before merge, though. |
zooba
approved these changes
Sep 7, 2022
|
Yep, this seems to be spot on. Nicely done! |
|
Thanks @CharlieZhao95 for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-96664 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 7, 2022
…tput files for frozen modules (pythonGH-96423) (cherry picked from commit 3e26de3) Co-authored-by: Charlie Zhao <zhaoyu_hit@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The files generated by
PCbuild\build.batin thePython\deepfreezeandPython\frozen_modulesdirectories may cause errors when rebuilding after a checkout.Now
PCbuild\clean.batcan correctly remove those previous output files.