Skip to content

gh-96587: Raise SyntaxError for PEP654 on older feature_version #96588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2022
Merged

gh-96587: Raise SyntaxError for PEP654 on older feature_version #96588

merged 1 commit into from
Sep 5, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Sep 5, 2022 •
edited by bedevere-bot
Loading

@pablogsal pablogsal merged commit 2c7d2e8 into python:main Sep 5, 2022
@pablogsal pablogsal added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Sep 5, 2022
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @sobolevn and @pablogsal, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 2c7d2e8d46164efb6e27a64081d8e949f6876515 3.10

@miss-islington
Copy link
Contributor

Sorry, @sobolevn and @pablogsal, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 2c7d2e8d46164efb6e27a64081d8e949f6876515 3.11

@pablogsal
Copy link
Member

@sobolevn Can you do the backports using cherry_picker?

@sobolevn
Copy link
Member Author

sobolevn commented Sep 5, 2022

Yes, sure, but only for 3.11
3.10 does not have except*

@pablogsal pablogsal removed the needs backport to 3.10 only security fixes label Sep 5, 2022
@pablogsal
Copy link
Member

pablogsal commented Sep 5, 2022 •
edited
Loading

3.10 does not have except*

Haha, yep, we are lucky you don't need to backport except* to 3.10 so you can also backport this ;)

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 5, 2022
@bedevere-bot
Copy link

GH-96591 is a backport of this pull request to the 3.11 branch.

sobolevn added a commit to sobolevn/cpython that referenced this pull request Sep 5, 2022
@sobolevn
[3.11] pythongh-96587: Raise SyntaxError for PEP654 on older `featu…
13c25df 
…re_version` (pythonGH-96588).

(cherry picked from commit 2c7d2e8)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
ambv pushed a commit that referenced this pull request Oct 5, 2022
@sobolevn
[3.11] gh-96587: Raise SyntaxError for PEP654 on older `feature_ver…
8c6ced3 
…sion` (GH-96588) (#96591)

(cherry picked from commit 2c7d2e8)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
@sobolevn @pablogsal
[3.11] gh-96587: Raise SyntaxError for PEP654 on older `feature_ver…
9cb7324 
…sion` (GH-96588) (#96591)

(cherry picked from commit 2c7d2e8)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@hauntsaninja hauntsaninja mentioned this pull request Nov 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees

@pablogsal pablogsal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sobolevn @miss-islington @pablogsal @bedevere-bot