Skip to content

GH-96678: Fix undefined behavior in ceval.c #96708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2022
Merged

GH-96678: Fix undefined behavior in ceval.c #96708

merged 1 commit into from
Sep 10, 2022

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Sep 9, 2022 •
edited by bedevere-bot
Loading

A minimal fix for easy porting to 3.11.

@markshannon markshannon added the needs backport to 3.11 only security fixes label Sep 9, 2022
@matthiasgoergens
Copy link
Contributor

Looks good to me. It's basically equivalent to my patch, only that it puts the NULL check in the caller.

@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 9, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @tiran for commit b9d89ad 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 9, 2022
gvanrossum
gvanrossum approved these changes Sep 9, 2022
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is the only call to _PyTuple_FromArraySteal this seems an adequate solution.

@pablogsal pablogsal merged commit 50a70a0 into python:main Sep 10, 2022
@miss-islington
Copy link
Contributor

Thanks @markshannon for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2022
@markshannon @miss-islington
pythonGH-96678: Fix undefined behavior in ceval.c (pythonGH-96708)
1bfcf1e 
(cherry picked from commit 50a70a0)

Co-authored-by: Mark Shannon <mark@hotpy.org>
@bedevere-bot
Copy link

GH-96732 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 10, 2022
miss-islington added a commit that referenced this pull request Sep 10, 2022
@miss-islington @markshannon
GH-96678: Fix undefined behavior in ceval.c (GH-96708)
7033dc8 
(cherry picked from commit 50a70a0)

Co-authored-by: Mark Shannon <mark@hotpy.org>
@markshannon markshannon deleted the fix-96678-minimal branch September 26, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@pablogsal pablogsal pablogsal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@markshannon @matthiasgoergens @bedevere-bot @miss-islington @gvanrossum @pablogsal @tiran