correct parse_qs and parse_qsl test case descriptions. #968
Conversation
|
@orsenthil, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ezio-melotti, @facundobatista and @ncoghlan to be potential reviewers. |
Lib/urllib/parse.py
Outdated
| @@ -633,6 +634,8 @@ def parse_qs(qs, keep_blank_values=False, strict_parsing=False, | |||
|
|
|||
| encoding and errors: specify how to decode percent-encoded sequences | |||
| into Unicode characters, as accepted by the bytes.decode() method. | |||
|
|
|||
| Returns a dictionary. | |||
There was a problem hiding this comment.
Indentation is less than the rest
|
@vadmium , thanks for the review. Took a chance to make the docstring of the other method consistently indented too. |
|
|
||
| Returns a list, as G-d intended. | ||
| Returns a list, as G-d intended. |
There was a problem hiding this comment.
Sorry to be nitpicky, but now this will have “Returns a list” indented underneath “Arguments:”, which seems wrong. I haven’t tried, butt I expect the help will look like
Parse a query . . .
Arguments:
qs: . . .
. . .
encoding and errors: . . .
Returns a list . . .
There was a problem hiding this comment.
No problem. I've addressed this comment. I didn't notice it earlier.
There was a problem hiding this comment.
FWIW: Here is the indentation that I verified.
It had wrong types written in test case descriptions.