bpo-34970: Protect tasks weak set manipulation in asyncio.all_tasks() #9837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st1
reviewed
Oct 13, 2018
Lib/asyncio/tasks.py
Outdated
| return {t for t in _all_tasks | ||
| # NB: set(_all_tasks) is required to protect | ||
| # from https://bugs.python.org/issue34970 bug | ||
| return {t for t in set(_all_tasks) |
There was a problem hiding this comment.
Can you make it a list() call instead of set()?
|
@asvetlov: Status check is done, and it's a success ✅ . |
|
Thanks @asvetlov for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 13, 2018
…pythonGH-9837) https://bugs.python.org/issue34970 (cherry picked from commit 97cf082) Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
|
GH-9849 is a backport of this pull request to the 3.7 branch. |
asvetlov
added a commit
that referenced
this pull request
Oct 13, 2018
…GH-9837) (GH-9849) https://bugs.python.org/issue34970 (cherry picked from commit 97cf082) Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
ned-deily
pushed a commit
to ned-deily/cpython
that referenced
this pull request
Oct 20, 2018
…pythonGH-9837) (pythonGH-9849) https://bugs.python.org/issue34970 (cherry picked from commit 97cf082) Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue34970