Skip to content

[3.10] argparse docs: normalize constant references (#98765) #98808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2022
Merged

[3.10] argparse docs: normalize constant references (#98765) #98808

merged 1 commit into from
Oct 28, 2022

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Oct 28, 2022 •
edited by miss-islington
Loading

(cherry picked from commit b27b57c)

Automerge-Triggered-By: GH:AlexWaygood

@bedevere-bot bedevere-bot mentioned this pull request Oct 28, 2022
Merged
@bedevere-bot bedevere-bot added skip issue skip news docs Documentation in the Doc dir labels Oct 28, 2022
@AlexWaygood AlexWaygood self-assigned this Oct 28, 2022
CAM-Gerlach
CAM-Gerlach approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (though I was a bit confused initially on why I was requested for review on a backport PR, but I'm guessing it was because it was a manual backport due to a merge conflict (the table not existing)

@AlexWaygood
Copy link
Member Author

I'm guessing it was because it was a manual backport due to a merge conflict (the table not existing)

Yup, just wanted a second pair of eyes to check I hadn't screwed up the cherry pick :)

@AlexWaygood AlexWaygood merged commit 4320115 into python:3.10 Oct 28, 2022
@AlexWaygood AlexWaygood deleted the backport-b27b57c-3.10 branch October 28, 2022 17:17
@AlexWaygood
Copy link
Member Author

Thanks for the review @CAM-Gerlach!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti

Assignees

@AlexWaygood AlexWaygood

Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexWaygood @CAM-Gerlach @bedevere-bot @smontanaro