-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-72496: Implemented patch to improve performance of string.Template #99177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
LGTM. @delta1513 Can you sign the the CLA and add a NEWS entry? |
@furkanonder I just realized that my old account @delta1512 (which I have been locked-out of) managed to still be on my system and somehow make its way into the commit and it's asking me to sign with that account. If necessary I will try and recover the account and sign the CLA, else I'm very sure that I've signed it as @delta1513 if only that is sufficient. Let me know if there are other options that will make merging this PR easier. As for the NEWS entry, I have it added. Please let me know if I got the format wrong or need to change anything. I apologize for the inconvenience, I am much more accustomed to Gitlab 😅 |
Sorry about the lack of activity, totally forgot I had this open. Going to see about getting this fixed up now that this is my main account 👍 |
c573847
to
66d074c
Compare
d6b37ca
to
5df55ee
Compare
The following commit authors need to sign the Contributor License Agreement: |
Implemented the patchfile from BPO 28309
Fixes #72496
As also noted in the issue thread, I noticed no performance improvements on my machine so someone else may want to verify whether these changes are actually beneficial.