Skip to content

gh-98718: add sys.build_prefix #99273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

FFY00
Copy link
Member

@FFY00 FFY00 commented Nov 9, 2022

Alternative to #98719, but exporting sys.build_prefix.

Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00 FFY00 force-pushed the bpo-98718-build_prefix branch from 7c3e199 to 3bc6847 Compare November 9, 2022 03:21
Signed-off-by: Filipe Laíns <lains@riseup.net>
@zooba
Copy link
Member

zooba commented Nov 9, 2022

I wonder if, rather than plumbing this the whole way through, we can simply assign it to the sys module in getpath.py? There's no real value in making this configurable, and honestly I'd rather remove or fix anything that requires this.

@FFY00
Copy link
Member Author

FFY00 commented Nov 10, 2022

Yes, I think that makes sense.

By configurable you are referring to setting it when embedding, right? I was under the impression we needed further changes to make that actually work.

@zooba
Copy link
Member

zooba commented Nov 10, 2022

By configurable you are referring to setting it when embedding, right? I was under the impression we needed further changes to make that actually work.

Just needs to be put into PyConfig and set up to be cleared/copied (as you've done). But on second thoughts, you're not going to be able to set the sys module directly here anyway, so probably it needs to go back into PyConfig at this stage.

If we're to go ahead with this, I'd make the PyConfig field private (leading underscore). Or if we can come up with a better way to set up the sys module from within getpath.py, I'd like that more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants