Skip to content

gh-99631: Add custom loads and dumps support for the shelve module #99632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from
Closed

gh-99631: Add custom loads and dumps support for the shelve module #99632

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
79bf61c
gh-99631: Add custom unpickler and pickler support for the shelve module
furkanonder Nov 20, 2022
0258c95
Merge branch 'python:main' into issue-99631
furkanonder Dec 3, 2022
ef7ba36
add custom loads & dumps test
furkanonder Dec 3, 2022
cfba257
use custom loads & dumps instead of custom pickler & unpickler
furkanonder Dec 3, 2022
24ebcdf
update custom loads & dumps test
furkanonder Dec 3, 2022
4c80767
Update document for custom_loads and custom_dumps
furkanonder Dec 3, 2022
64ea474
📜🤖 Added by blurb_it.
blurb-it[bot] Dec 5, 2022
7dfc0c7
use serializer & deserializer instead of custom_dumps & custom_loads
furkanonder Dec 7, 2022
bb9ffd8
Add custom error for missing serializer & deserializer
furkanonder Dec 9, 2022
534f475
add test cases for missing serializer & deserializer
furkanonder Dec 9, 2022
c9132f3
Update 2022-12-05-19-21-22.gh-issue-99631.WVkNJl.rst
furkanonder Dec 9, 2022
4d45669
add new testcases for shelve
furkanonder Dec 9, 2022
f2715d9
Merge branch 'issue-99631' of github-personal:furkanonder/cpython int…
furkanonder Dec 9, 2022
11cbfbf
remove unnecessary imports & white spaces
furkanonder Dec 9, 2022
f850663
Merge branch 'python:main' into issue-99631
furkanonder Dec 19, 2022
9ced2cd
use xor in the simply serializer & deserializer check
furkanonder Dec 19, 2022
e9ae1be
update DbfilenameShelf __init__ function as keyword-argument only
furkanonder Dec 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add custom loads & dumps test
  • Loading branch information
@furkanonder
furkanonder committed Dec 3, 2022
commit ef7ba367259e5f06fbfa4d2d6dab58043f6cac7c
17 changes: 17 additions & 0 deletions Lib/test/test_shelve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import shelve
import pickle
import os
from io import BytesIO

from test.support import os_helper
from collections.abc import MutableMapping
Expand Down Expand Up @@ -165,6 +166,22 @@ def test_default_protocol(self):
with shelve.Shelf({}) as s:
self.assertEqual(s._protocol, pickle.DEFAULT_PROTOCOL)

def test_custom_loads_and_dumps(self):
def custom_dumps(obj, protocol=None):
return bytes(f"{type(obj)}", 'utf-8')

def custom_loads(data):
value = BytesIO(data).read()
return value.decode("utf-8")

os.mkdir(self.dirname)
self.addCleanup(os_helper.rmtree, self.dirname)

with shelve.open(self.fn, custom_dumps=custom_dumps, custom_loads=custom_loads) as s:
num = 1
s['number'] = num
self.assertEqual(s['number'], f"{type(num)}")


class TestShelveBase:
type2test = shelve.Shelf
Expand Down