Skip to content

Add SQLite 3.33.0 for CPython #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

erlend-aasland
Copy link
Collaborator

@erlend-aasland
Copy link
Collaborator Author

@zooba, would you mind reviewing this?

@zooba
Copy link
Member

zooba commented Oct 7, 2020

Thanks. Ultimately, the review that I need to do is download and check in the source code myself to make sure it's unmodified, so I'll just push it directly.

(Also, my GitHub notifications is a dumpster fire, so I never see anything. Better to ping me on bugs.python.org)

@erlend-aasland
Copy link
Collaborator Author

Thanks. Ultimately, the review that I need to do is download and check in the source code myself to make sure it's unmodified, so I'll just push it directly.

Ok.

(Also, my GitHub notifications is a dumpster fire, so I never see anything. Better to ping me on bugs.python.org)

Got it!

@zooba
Copy link
Member

zooba commented Oct 7, 2020

to make sure it's unmodified

FWIW, this is a terrible pain, because they list their hashes as "sha3" without clarifying which length, and the hash for the .zip file doesn't match any of the ones I can generate 😆

Luckily they list the hashes for the main source file separately and those check out.

@zooba
Copy link
Member

zooba commented Oct 7, 2020

Okay, my tag is up: https://github.com/python/cpython-source-deps/tree/sqlite-3.33.0.0

In theory, your diff should collapse to nothing now, but I'm not sure how/when GitHub will figure that out.

@zooba zooba closed this Oct 7, 2020
@erlend-aasland erlend-aasland deleted the sqlite-3.33.x branch October 7, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants