Skip to content

Update patchcheck description #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 16, 2023
Merged

Update patchcheck description #1031

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4ec567
Update path to patchcheck.py
EvanLai88 Jan 15, 2023
35ecd7c
Update path to reindent.py and clear deleted file
EvanLai88 Jan 15, 2023
7c801b9
Link with `:cpy-file:` directly
EvanLai88 Jan 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions getting-started/pull-request-lifecycle.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,15 +249,14 @@ through the common patch generation checks. To run ``patchcheck``:

.. code-block:: dosbatch

python.bat Tools\scripts\patchcheck.py
python.bat Tools\patchcheck\patchcheck.py

The automated patch checklist runs through:

* Are there any whitespace problems in Python files?
(using ``Tools/scripts/reindent.py``)
(using :cpy-file:`Tools/patchcheck/reindent.py`)
* Are there any whitespace problems in C files?
* Are there any whitespace problems in the documentation?
(using ``Tools/scripts/reindent-rst.py``)
* Has the documentation been updated?
* Has the test suite been updated?
* Has an entry under ``Misc/NEWS.d/next`` been added?
Expand Down