Skip to content

Add PEG Parser experts #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Add PEG Parser experts #637

merged 1 commit into from
Oct 26, 2020

Conversation

lysnikolaou
Copy link
Member

No description provided.

@gvanrossum gvanrossum merged commit 178606f into python:master Oct 26, 2020
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I left a minor comment but feel free to ignore

@@ -338,6 +339,7 @@ memoryview
networking giampaolo.rodola,
object model benjamin.peterson, twouters
packaging tarek, lemburg, alexis, eric.araujo, dstufft, paul.moore
peg parser gvanrossum, pablogsal, lysnikolaou
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe PEG instead of "peg"?

@pablogsal
Copy link
Member

LGTM

I left a minor comment but feel free to ignore

Oh, I didn't realized that this was merged, my bad (I did the review on the phone and that is not clear from the UI)

@isidentical
Copy link
Member

isidentical commented Oct 28, 2020

Hey @lysnikolaou, today I tried to use the peg parser experts list on an issue, but apparently your bpo name is lys.nikolaou on the other hand list contains lysnikolaou, FYI. (tracker complains about non-existing user)

@lysnikolaou
Copy link
Member Author

Thanks for letting me know, @isidentical!

@lysnikolaou lysnikolaou deleted the peg-experts branch October 28, 2020 22:08
AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants