Skip to content

Build for unexisting translations are expectingly failing, should log it properly #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JulienPalard opened this issue Jul 30, 2017 · 1 comment

Comments

@JulienPalard
Copy link
Member

JulienPalard commented Jul 30, 2017

The line shell_out("git -C {} checkout {}".format(directory, branch)) is throwing an exception as the 3.7 branch does not exists in french translation, this is expected and don't crash the script. it just don't compile the unexisting translation.

It should be reported nicely instead of logging a whole stacktrace: misreading it the first time make me though the 3.7 english build was failing.

I'm currently fixing this.

Thoughts: I should probably build an untranslated version using po files from a near version… so if a new version spawn, we don't wait for translators teams to push the branch to build the docs.

@JulienPalard JulienPalard changed the title Build for 3.7 is failing due to unexisting 3.7 branch Build for unexisting translations are expectingly failing, should log it properly Jul 30, 2017
@JulienPalard
Copy link
Member Author

I'm experimenting a "fallback" to the nearest translated version, it make sense in cases like: a new version spawn (say 3.7), but translatiors are laggy to create their 3.7 branch, docsbuild will use po files from their 3.6 branch (almost identical files so it will work) so everyone can see it, crawlers can start indexing it, and it's up to each translations to fork the branch when the feel it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant