Shot in the dark fix for broken 3.10 render #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-aciek
approved these changes
Aug 6, 2022
There was a problem hiding this comment.
To my best knowledge it should fix the issue (I left a comment with a slight improvement). Sphinx version has been bumped on 3.10 doc requirements, but the script for generating the dependecies' pins has been not updated.
Probably it would be better to try to reuse requirements.txt of a build as long as it's not broken (for EOF Python version) to have one source of truth (we maintain the requirements.txt to be correct either way).
Co-authored-by: Maciej Olko <maciej.olko@affirm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CPython 3.10 docs have been repeatedly breaking, see python/cpython#91483
It seems likely to me that this is related to python/cpython#93159 (although the timeline doesn't match closely)