Skip to content

FIX issue 16: Build missing translations branches with nearest one. #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2017
Merged

FIX issue 16: Build missing translations branches with nearest one. #17

merged 1 commit into from
Aug 1, 2017

Conversation

JulienPalard
Copy link
Member

@JulienPalard JulienPalard commented Jul 30, 2017 •
edited
Loading

see: #16

I first though missing translations (typiaclly 3.7) should fail more cleanly than an exception logged with full stacktrace, probably something like "INFO: No translation for branch 3.7 in lang fr". But doing so I though we should probably just build them with the nearest translation, like 3.6, as lots of string are in common.

Tested locally with:

python3 ./build_docs.py --git --build-root /tmp/build_root/ --www-root /srv/docs.python.org --log-directory /tmp/log_root/ --skip-cache --quick

@JulienPalard JulienPalard mentioned this pull request Jul 31, 2017
Merged
@JulienPalard JulienPalard merged commit 6922a3d into python:master Aug 1, 2017
@JulienPalard JulienPalard deleted the issue16-3.7-fr branch October 15, 2017 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JulienPalard