Skip to content

Fix TypeError in setup_switchers() #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2025
Merged

Fix TypeError in setup_switchers() #284

merged 1 commit into from
Apr 13, 2025

Conversation

AA-Turner
Copy link
Member

No description provided.

@AA-Turner AA-Turner requested a review from hugovk April 13, 2025 10:26
@AA-Turner AA-Turner mentioned this pull request Apr 13, 2025
Merged
hugovk
hugovk approved these changes Apr 13, 2025
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to fixing the bug, can we have failing builds fail the CI, so they don't pass silently?

@AA-Turner
Copy link
Member Author

#286 is an attempt at that

@AA-Turner AA-Turner merged commit 982c0f8 into main Apr 13, 2025
10 checks passed
@AA-Turner AA-Turner deleted the switchers-content branch April 13, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AA-Turner @hugovk