-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
incremental: Crash after deleting a function. #3052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
FWIW, I couldn't actually reproduce this with (inside the Zulip directory):
|
Yeah the missing info is all the mtimes of the files in Tim's working directory when it failed. :-( |
(FWIW if this occurs again on an open source package, as of mypy 0.521 the mtimes in the |
I think @hackerkid saw this earlier today in the Zulip project; but we may be a bit behind 0.521 (haven't updated since PyCon). |
I got the error after I switched from a branch invite-link which had the model During each switch I did
I have attached the tar of my Zulip directory including the cache here. Update: fixed the get-user-2g-link. Thanks ethanhs |
(the correct get-user-2g link) @hackerkid did this happen consistently? Could you try updating the version of Mypy that you use? It appears your version is old. |
I downloaded the tarball but could not repro the issue with mypy 0.521, so I think it's not worth looking into further. Let us know whether you still see this with master. |
Hmm, I've definitely seen this since 0.521. I just upgraded to the latest mypy master in case that helps; will let you know when I next see it (it's about once a week, usually after a series of switches between branches including one that deletes things). |
If and when you see it, tarring up your entire zulip tree (.git and all) like @hackerkid did would be very helpful. |
We've seen a similar crash internally, where the assert referenced a class that was deleted by the change. Sadly it was also impossible to repro. Which means that at least the work-around of deleting the cache shouldn't be too painful. |
An internal user claims this can be reproduced as follows:
The edit in step 2 could be a whitespace edit, as long as it's a type-checked file. |
@gvanrossum I now have a simple repro for this crash inspired by #4043. Here is the recipe: Initial setup: # a.py
from b import x
# b.py
from c import x
# c.py
x = 1 with any previous mypy caches removed. Steps to reproduce:
|
I ran into this crash with 0.501 today on the Zulip codebase when running mypy with this version of the code zulip/zulip@09f66b5 (which deleted the below function).
I've attached the cache state tarball in case it's helpful: mypy.tar.gz
The text was updated successfully, but these errors were encountered: