Extend the dataclass plugin to deal with callable properties #10292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At runtime, the callable properties of dataclasses are handled in the way one would expect: they are not passed a `self` argument. Mypy, however, just sees them as callable class attributes and generates errors about missing arguments. This is a special case of what is discussed in python#708. I donʼt have a general solution for that problem, but for dataclasses, I can fix it by automatically converting the callable entries in a data class into (settable) properties. That makes them work properly via-a-vis the typechecker.
aecay
added a commit
to sky-uk/mite
that referenced
this pull request
Apr 7, 2021
this is (hopefully) temporary until python/mypy#10292 is merged
aecay
added a commit
to sky-uk/mite
that referenced
this pull request
Apr 7, 2021
this is (hopefully) temporary until python/mypy#10292 is merged
|
The travis failure is in the python3.5 unit test job, which fails before the tests even run: This same job passed on fb07856, and I can't see where the changes in 6149640 would have caused it to start failing... So it looks like a transient issue. When I try to rerun the job on Travis, I get an error ("could not rerun job") -- maybe a permissions issue? In any case, I figured it makes sense to wait for reviews and maybe a little help coaxing the CI to rerun rather than keep bashing away at it for the moment. |
|
I used the powers vested in me to click the "Re-run job button" in Travis. For future reference, closing and reopening the PR tends to work too. |
JukkaL
approved these changes
Apr 23, 2021
wyfo
added a commit
to wyfo/mypy
that referenced
this pull request
May 26, 2021
…ython#10292)" This reverts commit 3996f43.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At runtime, the callable properties of dataclasses are handled in the
way one would expect: they are not passed a
selfargument. Mypy,however, just sees them as callable class attributes and generates
errors about missing arguments. This is a special case of what is
discussed in #708. I donʼt have a general solution for that problem,
but for dataclasses, I can fix it by automatically converting the
callable entries in a data class into (settable) properties. That makes
them work properly via-a-vis the typechecker.
(Explain how this PR changes mypy.)
Test Plan
Added unit tests which verify: