Add boto3 and botocore legacy stubs #10615
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This seems like a good idea. However, we are still figuring out the best way to suggest stubs from outside of typeshed (see #10619). If/when we decide on how to deal with adding suggested stubs generally, we can add boto3 and botocore stubs to suggestions. |
|
Diff from mypy_primer, showing the effect of this PR on open source code: prefect (https://github.com/PrefectHQ/prefect.git)
+ src/prefect/engine/results/s3_result.py:7: error: Library stubs not installed for "boto3" (or incompatible with Python 3.8)
+ src/prefect/engine/results/s3_result.py:76: error: Library stubs not installed for "botocore.exceptions" (or incompatible with Python 3.8)
+ src/prefect/engine/results/s3_result.py:139: error: Library stubs not installed for "botocore" (or incompatible with Python 3.8)
+ src/prefect/storage/s3.py:157: error: Library stubs not installed for "botocore.exceptions" (or incompatible with Python 3.8)
+ src/prefect/environments/execution/fargate/fargate_task.py:386: error: Library stubs not installed for "boto3" (or incompatible with Python 3.8)
+ src/prefect/environments/execution/fargate/fargate_task.py:387: error: Library stubs not installed for "botocore.exceptions" (or incompatible with Python 3.8)
+ src/prefect/agent/fargate/agent.py:145: error: Library stubs not installed for "boto3" (or incompatible with Python 3.8)
+ src/prefect/agent/fargate/agent.py:145: note: Hint: "python3 -m pip install types-boto3"
+ src/prefect/agent/fargate/agent.py:147: error: Library stubs not installed for "botocore.config" (or incompatible with Python 3.8)
+ src/prefect/agent/fargate/agent.py:229: error: Library stubs not installed for "botocore.exceptions" (or incompatible with Python 3.8)
+ src/prefect/agent/ecs/agent.py:167: error: Library stubs not installed for "botocore.config" (or incompatible with Python 3.8)
+ src/prefect/agent/ecs/agent.py:167: note: Hint: "python3 -m pip install types-botocore"
+ src/prefect/utilities/aws.py:10: error: Library stubs not installed for "boto3" (or incompatible with Python 3.8)
+ src/prefect/utilities/aws.py:14: error: Library stubs not installed for "botocore" (or incompatible with Python 3.8)
+ src/prefect/utilities/aws.py:14: error: Library stubs not installed for "botocore.client" (or incompatible with Python 3.8)
core (https://github.com/home-assistant/core.git)
+ homeassistant/components/route53/__init__.py:7: error: Library stubs not installed for "boto3" (or incompatible with Python 3.8) [import]
+ homeassistant/components/amazon_polly/tts.py:7: error: Library stubs not installed for "boto3" (or incompatible with Python 3.8) [import]
+ homeassistant/components/amazon_polly/tts.py:7: note: Hint: "python3 -m pip install types-boto3"
+ homeassistant/components/amazon_polly/tts.py:8: error: Library stubs not installed for "botocore" (or incompatible with Python 3.8) [import]
+ homeassistant/components/amazon_polly/tts.py:8: note: Hint: "python3 -m pip install types-botocore"
dragonchain (https://github.com/dragonchain/dragonchain.git)
+ dragonchain/lib/interfaces/aws/sns.py:20:1: error: Library stubs not installed for "boto3" (or incompatible with Python 3.8)
+ dragonchain/lib/interfaces/aws/ecr.py:21:1: error: Library stubs not installed for "boto3" (or incompatible with Python 3.8)
+ dragonchain/lib/interfaces/aws/ecr.py:21:1: note: Hint: "python3 -m pip install types-boto3"
+ dragonchain/lib/interfaces/aws/s3.py:21:1: error: Library stubs not installed for "boto3" (or incompatible with Python 3.8)
+ dragonchain/lib/interfaces/aws/s3.py:22:1: error: Library stubs not installed for "botocore" (or incompatible with Python 3.8)
+ dragonchain/lib/interfaces/aws/s3.py:22:1: note: Hint: "python3 -m pip install types-botocore"
+ dragonchain/lib/interfaces/aws/s3_utest.py:21:1: error: Library stubs not installed for "botocore" (or incompatible with Python 3.8)
- dragonchain/job_processor/contract_job_utest.py:454:9: error: Cannot assign to a method
- dragonchain/job_processor/contract_job_utest.py:455:9: error: Cannot assign to a method
- dragonchain/job_processor/contract_job_utest.py:456:9: error: Cannot assign to a method
- dragonchain/job_processor/contract_job_utest.py:458:9: error: Cannot assign to a method
- dragonchain/job_processor/contract_job_utest.py:459:9: error: Cannot assign to a method
- dragonchain/job_processor/contract_job_utest.py:465:9: error: Cannot assign to a method
- dragonchain/job_processor/contract_job_utest.py:466:9: error: Cannot assign to a method
- dragonchain/job_processor/contract_job_utest.py:467:468: note: (Skipping most remaining errors due to unresolved imports or missing stubs; fix these first)
+ dragonchain/job_processor/contract_job_utest.py:454:455: note: (Skipping most remaining errors due to unresolved imports or missing stubs; fix these first)
scrapy (https://github.com/scrapy/scrapy.git)
+ scrapy/utils/boto.py:21: error: Library stubs not installed for "botocore" (or incompatible with Python 3.8)
- scrapy/utils/versions.py:4: note: (or run "mypy --install-types" to install all missing stub packages)
+ scrapy/extensions/feedexport.py:131: error: Library stubs not installed for "botocore" (or incompatible with Python 3.8)
+ scrapy/extensions/feedexport.py:131: error: Library stubs not installed for "botocore.session" (or incompatible with Python 3.8)
+ scrapy/pipelines/files.py:95: error: Library stubs not installed for "botocore" (or incompatible with Python 3.8)
+ scrapy/pipelines/files.py:95: error: Library stubs not installed for "botocore.session" (or incompatible with Python 3.8)
+ scrapy/core/downloader/handlers/s3.py:33: error: Library stubs not installed for "botocore" (or incompatible with Python 3.8)
+ scrapy/core/downloader/handlers/s3.py:33: error: Library stubs not installed for "botocore.auth" (or incompatible with Python 3.8)
+ scrapy/core/downloader/handlers/s3.py:33: note: (or run "mypy --install-types" to install all missing stub packages)
+ scrapy/core/downloader/handlers/s3.py:33: note: Hint: "python3 -m pip install types-botocore"
- scrapy/utils/versions.py:4: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
+ scrapy/core/downloader/handlers/s3.py:33: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
+ scrapy/core/downloader/handlers/s3.py:34: error: Library stubs not installed for "botocore.credentials" (or incompatible with Python 3.8)
+ scrapy/core/downloader/handlers/s3.py:63: error: Library stubs not installed for "botocore.awsrequest" (or incompatible with Python 3.8)
+ tests/test_feedexport.py:284: error: Library stubs not installed for "botocore.stub" (or incompatible with Python 3.8)
paasta (https://github.com/yelp/paasta.git)
+ paasta_tools/kubernetes/bin/paasta_cleanup_stale_nodes.py:32: error: Library stubs not installed for "boto3" (or incompatible with Python 3.7)
+ paasta_tools/kubernetes/bin/paasta_cleanup_stale_nodes.py:34: error: Library stubs not installed for "botocore.exceptions" (or incompatible with Python 3.7)
+ paasta_tools/kubernetes/bin/paasta_cleanup_stale_nodes.py:34: note: Hint: "python3 -m pip install types-botocore"
+ paasta_tools/paasta_remote_run.py:30: error: Library stubs not installed for "boto3.session" (or incompatible with Python 3.7)
+ paasta_tools/cli/cmds/spark_run.py:17: error: Library stubs not installed for "boto3.exceptions" (or incompatible with Python 3.7)
+ paasta_tools/cli/cmds/spark_run.py:17: note: Hint: "python3 -m pip install types-boto3"
pandas (https://github.com/pandas-dev/pandas.git)
+ pandas/io/common.py:343: error: Library stubs not installed for "botocore.exceptions" (or incompatible with Python 3.8) [import]
+ pandas/io/common.py:343: note: Hint: "python3 -m pip install types-botocore"
+ pandas/tests/io/conftest.py:111: error: Library stubs not installed for "boto3" (or incompatible with Python 3.8) [import]
+ pandas/tests/io/conftest.py:111: note: Hint: "python3 -m pip install types-boto3"
+ pandas/tests/io/test_s3.py:16: error: Library stubs not installed for "botocore.response" (or incompatible with Python 3.8) [import]
+ pandas/tests/io/parser/test_network.py:219: error: Library stubs not installed for "botocore" (or incompatible with Python 3.8) [import]
|
|
@JukkaL thank you for a quick response! Probably, I am not sure if it should be done on a regular I will keep the PR open for now. |
|
@vemel that's too risky because anyone can upload things to PyPI, and installing packages can execute arbitrary code. In addition, low-quality stubs packages can lead to more problems than they solve. We need some sort of vetting. |
|
Hello! Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
types-botocoreandtypes-boto3stub packages forbotocoreandboto3respectively.These type annotations are built automatically with mypy_boto3_builder and updated on a new
boto3/botocorerelease.This is a great idea to install missing type annotations with
mypy, thank you!