Fixed: Auto Discovery of .test files Fixes #8650 #11445
Conversation
| 'check-slots.test', | ||
| 'check-formatting.test' | ||
| ] | ||
| test_path = '../../test-data/unit/' |
There was a problem hiding this comment.
This won't work on windows. Use os.path / pathlib
There was a problem hiding this comment.
Surprisingly enough, using forward slashes doesn't break this on Windows. Windows supports using forward slashes in file paths in most cases (There are some edge cases where only backslashes are allowed in file paths, but this doesn't seem to be one of those situations).
That being said, using pathlib is probably a good idea for this considering that it's probably more portable than just using forward slashes and because it would probably make it easier to make this path relative to the current file's path (which I believe is necessary to fix the CI failures).
| 'check-formatting.test' | ||
| ] | ||
| test_path = '../../test-data/unit/' | ||
| typecheck_files = [f for f in listdir(test_path) if isfile(join(test_path, f)) and f.startswith('check-')] |
There was a problem hiding this comment.
listdir won't recurse into nested folders if we ever have one.
There was a problem hiding this comment.
ok, so I also need to check for test files in deeper repositories as well right? I'll get on it, soon.
Fixed: issue #8650
On merging this PR, the testcheck.py script will automatically walk the test file directory and record all the test files starting with 'check-'. This is very crucial in order for this problem to not emerge in future endeavors when new test files are added into the repository, as the file searching is automated to detect any new such files.
This approach is not using regex, rather uses simple python os library methods.
The changes have been verified on my local system, the py script after changes runs smoothly. The newly detected test files are shown in this helper local python script terminal:
It would be great if this PR is authorized, I could henceforth start my journey to contributing to mypy after this.
Thanks @JukkaL @ethanhs @davidzwa