Tests autodiscovery replacing hardcoded file list #13143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odesenfans
reviewed
Jul 16, 2022
|
@ilevkivskyi The checks are all green, I think we're all good to merge it now 🙂 |
ilevkivskyi
approved these changes
Jul 17, 2022
|
Since #13138 silently broke many of our tests, I thought I'd double check this as well. Tests for Python 3.10 on 6f93fc1 (with this PR) Tests for Python 3.10 on b6d525d (without this PR) Any idea what 2 tests we lost? |
|
cc @evemorgen |
|
I'll look into that later today |
|
@hauntsaninja Yeah, that's right, it looks the like two tests have been lost for any reason. I'll post a PR with a fix shortly. > diff test-310-pr.log test-310-prev.log
5272a5273,5274
> <DataDrivenTestCase testLiteralSemanalBasicAssignment>
> <DataDrivenTestCase testLiteralSemanalInFunction>
10311a10314
10879c10882
< ======================== 10537 tests collected in 0.46s ========================
---
> ======================== 10539 tests collected in 0.42s ======================== |
|
@hauntsaninja - #13175 this PR reintroduces missing tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR hopefully resolves #8650.
The main change is the
find_test_fileshelper function that looks for files matching the pattern in the unit tests directory. It has been used in the following test files for autodiscovery:testcheck.pytestdeps.pytestfinegrained.pytestparse.pytestsemanal.pyI've also updated the readme.
Test Plan
This is a question for maintainers - does this helper function needs unit tests and if so, where should they live? I haven't found
testhelpers.py🙂