(🐞) Fix CI python interpreter #13168
Conversation
There was a problem hiding this comment.
Huh. Thanks for catching this. Any idea why / when it broke? Also why does it work on Windows? https://github.com/python/mypy/runs/7377272863?check_suite_focus=true
Other tox environments look to be affected too, e.g. flake8 (although I feel like I've had flake8 fail on me somewhat recently).
|
Okay, I see #13138. Still not sure why it works on Windows. |
|
I have no idea why windows passed, probably due to some mysterious property/setting that it has and the others don't |
This comment has been minimized.
This comment has been minimized.
|
@hauntsaninja Do we actually want to run the type check with a 3.10 interpreter? idk if that's the best idea. |
|
Running type check with 3.10 interpreter should be fine, see https://github.com/python/mypy/pull/13138/files#r922690360 |
|
We should also do something like tox-dev/tox#631 (comment) |
This comment has been minimized.
This comment has been minimized.
I don't think that's the best bet: playground |
This comment has been minimized.
This comment has been minimized.
4 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
Hmm, fair point. It's on the verge of being too late, but here you go: python/cpython#94948 |
|
Also python/cpython#94950. Got any others? :-) |
|
and |
Pep 614 |
PEP 570 |
|
Unparenthesized unpack on |
PEP 461 https://mypy-play.net/?mypy=latest&python=3.4&gist=118df5de911012759ae74530ce3f5cfd |
Parenthesized keyword arguments: https://mypy-play.net/?mypy=latest&python=3.6&gist=e11926868a9678f9ee9383be4ebceba9 |
Unparenthesized lambda in comprehension: |
Unparenthesized assignment expression in set literal, set comprehension and sequence index: https://mypy-play.net/?mypy=latest&python=3.9&gist=c344a87c9745e47cd55ef10c71f9e923 |
This change will mean that
tox -e typewill use your current interpreter instead of 3.7, this could be good or bad depending on how you look at it.Also added an override in CI to not skip missing interpreters.