Skip to content

Fix teststubtest for the upcoming typeshed sync #13447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2022
Merged

Fix teststubtest for the upcoming typeshed sync #13447

merged 1 commit into from
Aug 19, 2022

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Aug 18, 2022 •
edited
Loading

This is a PR to the jhance-typeshed branch. This PR should make CI on #13386 go green.

@AlexWaygood AlexWaygood mentioned this pull request Aug 18, 2022
Merged
@AlexWaygood AlexWaygood changed the title Fix teststubtest Fix teststubtest for the upcoming typeshed sync Aug 18, 2022
sobolevn
sobolevn reviewed Aug 18, 2022
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried this locally? Error does seem too cryptic to me 🙁

@AlexWaygood
Copy link
Member Author

AlexWaygood commented Aug 18, 2022 •
edited
Loading

Have you tried this locally? Error does seem too cryptic to me 🙁

Yep, I tried it locally with #13386 checked out. I reproduced the test failure in CI locally without this patch applied, and confirmed that teststubtest passes with this change applied :)

@AlexWaygood
Copy link
Member Author

AlexWaygood commented Aug 18, 2022 •
edited
Loading

Anyhow, this is a PR to the jhance-typeshed branch that's being used for #13386, so if the CI on this PR goes green, we'll know it fixes the issue.

@JelleZijlstra JelleZijlstra merged commit 2ec37f5 into python:jhance-typeshed Aug 19, 2022
@AlexWaygood AlexWaygood deleted the jhance-typeshed branch August 19, 2022 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexWaygood @sobolevn @JelleZijlstra