Fix return values of DictProxy.{items,values} in the typeshed #13811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
approved these changes
Oct 4, 2022
|
Sorry I thought this was on the typeshed repo, not the mypy repo. We shouldn't change this directly in mypy; instead we should fix it in typeshed and bring it in with the next typeshed sync. |
|
Typeshed was already fixed in python/typeshed#8815. |
|
Sorry I didn't know that the typeshed was another repository synced in mypy. Do you have an idea of when the next typeshed sync will be done and released? |
|
I believe the next release (0.990) should be in about a month. We will sync typeshed before then. |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12982 is introducing the type
DictProxyin the typeshed but the return values got mixed up between the methodvaluesanditems.