Unpin the types-setuptools build dependency
#14787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest release of `types-setuptools` is causing type-check errors (and, therefore, build errors) on the `master` branch: see, e.g. https://github.com/python/mypy/actions/runs/4275505309/jobs/7442902732. python#14781 addressed some of the new errors, but didn't quite fix the build.
JelleZijlstra
approved these changes
Feb 26, 2023
mastermaster caused by the latest release of types-setuptools
|
Okay, it looks like this PR currently gets us to a place where the mypyc build succeeds (further than we get on |
AlexWaygood
added a commit
to AlexWaygood/mypy
that referenced
this pull request
Feb 26, 2023
The mypyc build is failing on `master` due to the latest release of `types-setuptools`: see, e.g. https://github.com/python/mypy/actions/runs/4275505309/jobs/7442902732. python#14787 fixes the _build_ but there's still a bunch of mypyc tests failing on that PR. I haven't got time to debug them right now (and I'm not a mypyc expert, anyway!), so this is a stopgap PR to pin `types-setuptools` so that we avoid the latest release.
|
I haven't got time to debug the failing tests right now, so here's a stopgap PR pinning |
JelleZijlstra
pushed a commit
that referenced
this pull request
Feb 26, 2023
The mypyc build is failing on `master` due to the latest release of `types-setuptools`: see, e.g. https://github.com/python/mypy/actions/runs/4275505309/jobs/7442902732. #14787 fixes the mypyc _build_, but there's still a bunch of mypyc tests failing on that PR. I haven't got time to debug them right now (and I'm also not particularly knowledgeable about mypyc!), so this is a stopgap PR to pin `types-setuptools` so that we avoid the latest release.
mypyc/build.py
Outdated
|
|
||
| if not use_setuptools: | ||
| from distutils.core import Extension | ||
| from distutils.core import Extension as extension_class |
There was a problem hiding this comment.
Suggested change
| from distutils.core import Extension as extension_class | |
| import distutils.core | |
| extension_class = distutils.core.Extension |
Just a hunch
There was a problem hiding this comment.
Trying it out now...
master caused by the latest release of types-setuptoolstypes-setuptools build dependency
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
| @@ -12,7 +12,7 @@ requires = [ | |||
| "tomli>=1.1.0; python_version<'3.11'", | |||
| # the following is from build-requirements.txt | |||
| "types-psutil", | |||
| "types-setuptools<67.4.0.2", # TODO: fix build when using the latest version of types-setuptools | |||
| "types-setuptools", | |||
There was a problem hiding this comment.
Does this need a lower bound?
There was a problem hiding this comment.
I don't think it needs one -- #14781 had successful CI runs with types-setuptools==67.4.0.1, e.g. https://github.com/python/mypy/actions/runs/4272132207/jobs/7437069696. But I can add one anyway to be sure, if you like -- it probably wouldn't hurt. Would you prefer that?
Closed
AlexWaygood
added a commit
to AlexWaygood/mypy
that referenced
this pull request
Mar 2, 2023
- The latest release of `types-setuptools` started causing type-check errors (and, therefore, mypyc build errors) on the `master` branch: see, e.g. https://github.com/python/mypy/actions/runs/4275505309/jobs/7442902732. - python#14781 addressed some of the new errors, but didn't quite fix the build. - python#14788 then pinned the `types-setuptools` dependency as a temporary stopgap measure. - This PR now attempts to unpin `types-setuptools` and fix the build errors in a more principled way.
JelleZijlstra
pushed a commit
that referenced
this pull request
Mar 2, 2023
The mypyc build was recently broken by a new release of `types-setuptools`. This was fixed on `master` by the following two PRs: - #14781 - #14787 However, the mypyc build is still broken on the 1.1 branch: https://github.com/python/mypy/actions/runs/4311688115/jobs/7521345529. This PR cherry-picks the two PRs that fixed the build to the 1.1 branch. --------- Co-authored-by: Avasam <samuel.06@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
types-setuptoolsstarted causing type-check errors (and, therefore, mypyc build errors) on themasterbranch: see, e.g. https://github.com/python/mypy/actions/runs/4275505309/jobs/7442902732.types-setuptoolsto <67.4.0.2 #14788 then pinned thetypes-setuptoolsdependency as a temporary stopgap measure.types-setuptoolsand fix the build errors in a more principled way.