Skip to content

teststubtest: assert on output without color #15292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 24, 2023
Merged

teststubtest: assert on output without color #15292

merged 2 commits into from
May 24, 2023

Conversation

ikonst
Copy link
Contributor

@ikonst ikonst commented May 24, 2023

These tests have been failing when running in some terminals:

FAILED mypy/test/teststubtest.py::StubtestMiscUnit::test_allowlist - AssertionError: assert '\x1b[1m\x1b[...x1b(B\x1b[m\n' == 'Success: no ...in 1 module\n'
FAILED mypy/test/teststubtest.py::StubtestMiscUnit::test_config_file - AssertionError: assert '\x1b[1m\x1b[...x1b(B\x1b[m\n' == 'Success: no ...in 1 module\n'
FAILED mypy/test/teststubtest.py::StubtestMiscUnit::test_ignore_flags - AssertionError: assert '\x1b[1m\x1b[...x1b(B\x1b[m\n' == 'Success: no ...in 1 module\n'

@ikonst
Copy link
Contributor Author

ikonst commented May 24, 2023

👋 @hauntsaninja

ikonst
ikonst commented May 24, 2023
View reviewed changes
mypy/test/teststubtest.py
@@ -1866,7 +1865,7 @@ def test_output(self) -> None:
f"Runtime: in file {TEST_MODULE_NAME}.py:1\ndef (num, text)\n\n"
"Found 1 error (checked 1 module)\n"
)
assert remove_color_code(output) == expected
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consolidated in run_stubtest

hauntsaninja
hauntsaninja approved these changes May 24, 2023
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The test failures are probably caused by the new release of typing_extensions and we'd need a typeshed update or something to fix

@JelleZijlstra
Copy link
Member

I had to deal with the same thing: quora/pyanalyze@a3f8115#diff-6d6be62a11d12e41348b409cfaddd9ea8161e2f78804ae5a7820b6c7197bb8bc. Probably not fixable in typeshed.

@AlexWaygood
Copy link
Member

I had to deal with the same thing: quora/pyanalyze@a3f8115#diff-6d6be62a11d12e41348b409cfaddd9ea8161e2f78804ae5a7820b6c7197bb8bc. Probably not fixable in typeshed.

#15294 is the fix.

@ikonst
Copy link
Contributor Author

ikonst commented May 24, 2023

@hauntsaninja merge?

@JelleZijlstra JelleZijlstra merged commit 5d6b0b6 into python:master May 24, 2023
@ikonst ikonst deleted the teststubtest-remove_color branch May 24, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ikonst @JelleZijlstra @AlexWaygood @hauntsaninja