Stubtest: add some hacks so that sys.monitoring is checked in typeshed's CI
#16269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would propose changing this in CPython :( |
It's not the design I would have chosen, for sure. There was discussion on this in the original PR that implemented the feature: python/cpython#103083 (comment) Perhaps Mark would be receptive to this being changed, reading through the comments again. I'm not sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in typeshed's CI, stubtest isn't detecting that
sys.monitoringis missing from typeshed. Even if you addsys.monitoringstubs to typeshed, stubtest doesn't verify that any of the details aboutsys.monitoringare correct, sincesys.monitoringis somewhat unique: it's a genuine instance oftypes.ModuleTypein the global namespace of thesysmodule, butimport sys.monitoringwill fail at runtime (sysisn't a package).I verified locally that these changes cause stubtest to start complaining about
sys.monitoringbeing missing with typeshed's current setup; and, if python/typeshed#10890 were merged, these changes here would cause stubtest to start complaining if there were any inaccuracies between the runtime and the stubs forsys.monitoring