Allow to use Final and ClassVar after python 3.13 #18358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mypy/typeanal.py
Outdated
| @@ -605,7 +605,7 @@ def try_analyze_special_unbound_type(self, t: UnboundType, fullname: str) -> Typ | |||
| t, | |||
| code=codes.VALID_TYPE, | |||
| ) | |||
| else: | |||
| elif self.options.python_version < (3, 13): | |||
There was a problem hiding this comment.
We should still error in several of the cases this previously triggered, e.g. def f(x: Final[int]) -> int: ... (grep the test cases for Final can be only used as an outermost qualifier for examples)
for more information, see https://pre-commit.ci
This comment has been minimized.
This comment has been minimized.
mypy/semanal.py
Outdated
| @@ -5080,7 +5084,9 @@ def check_classvar(self, s: AssignmentStmt) -> None: | |||
| node = lvalue.node | |||
| if isinstance(node, Var): | |||
| node.is_classvar = True | |||
| analyzed = self.anal_type(s.type) | |||
| analyzed = self.anal_type( | |||
| s.type, allow_final_in_classvar=self.options.python_version >= (3, 13) | |||
There was a problem hiding this comment.
I think this one might be unnecessary? Let me push to your PR
for more information, see https://pre-commit.ci
hauntsaninja
approved these changes
Dec 30, 2024
|
@hauntsaninja Thank you very much! |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Thanks for making a great library! I've been using mypy for years and it saved me from several (possibly happened) accidents!
Description
this PR allows to use Final and ClassVar after python 3.13
I saw this PR
and I saw recent changes of python 3.13
https://docs.python.org/3/library/typing.html#typing.Final
Final now can be nested with ClassVar. so I added a version check!