Refactor: extract logic in Options.__init__ into helper methods #19011
Conversation
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
There was a problem hiding this comment.
A long __init__ method that initializes attributes is arguably one case where splitting into multiple methods is not desirable, since our informal convention is to define all attributes in __init__. In the future we might even introduce a check to generate an error if an attribute is defined outside __init__ or the class body.
Defining attributes in the class body is not a good workaround either, since then we'd have declarations and initializations far away from each other, which is again not ideal. So unfortunately this is probably one of the few long methods where splitting it up doesn't seem worth it.
This pull request contributes to issue #5917, which encourages the decomposition of overly long methods to improve code clarity and maintainability.
Summary of changes
Refactored
Options.__init__by extracting its logic into several private helper methods:_initialize_caches_initialize_build_options_initialize_disallow_options_initialize_warning_and_reporting_options_initialize_misc_behavior_initialize_error_code_controls_initialize_target_definitions_initialize_caching_options_initialize_integration_flags_initialize_development_options_initialize_test_options_initialize_experimental_optionsNotes
This is a pure refactor in line with issue #5917.