feat: new mypyc primitives for weakref.proxy #19217
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0247068 to
c14c3a4
Compare
c14c3a4 to
c7608fb
Compare
This was referenced Aug 2, 2025
5117b20 to
834e739
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
Tests are fixed, this PR is now ready for review. |
for more information, see https://pre-commit.ci
6bde2ab to
652de32
Compare
JukkaL
reviewed
Aug 15, 2025
|
Thanks for the feedbacks, I've addressed all of them and this PR is again ready for review. |
|
Hmm.. what happened here? the testutil import broke the tests? |
|
@JukkaL any idea why replacing its another typeshed thing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 2 new weakref primitives for weakref.proxy (1 and 2 arg)
The C code generates correctly, but I'm not entirely sure why this test is failing. The weakly-proxied object is being destroyed too early, while there should still be a strong reference to it. It also fails if we use the builtin weakref.proxy, so I believe this might be exposing a reference counting bug unrelated to this PR.