Prevent a crash when InitVar is redefined with a method in a subclass #19453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
hauntsaninja
approved these changes
Jul 16, 2025
ilevkivskyi
reviewed
Jul 17, 2025
| # be reachable from the containing class by its name. | ||
| # The redefinition is never removed, use this as a sanity check to verify | ||
| # the reasoning above. | ||
| assert f"{defn.name}-redefinition" in defn.info.names |
There was a problem hiding this comment.
@sterliakov What about multiple redefinitions? Will this fix still work? The current logic in semanal.py is
if i == 1:
new_name = f"{name}-redefinition"
else:
new_name = f"{name}-redefinition{i}"There was a problem hiding this comment.
The first redefinition cannot be InitVar, so should not get deleted. I can replace this with any(name.startswith(f"{defn.name}-redifinition") for name in info.names), but I couldn't invent the case where name-redefinition is also gone
There was a problem hiding this comment.
OK, if you can't trigger it, it is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19443. This case is too niche (and should be trivially avoidable), so just not crashing should be good enough. The value is indeed redefined, and trying to massage the plugin to move the
X-redefinitionback toXin names is not worth the effort IMO.