Skip to content

Cleanup old ast classes in fastparse #19743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2025
Merged

Cleanup old ast classes in fastparse #19743

merged 1 commit into from
Aug 27, 2025

Conversation

cdce8p
Copy link
Collaborator

@cdce8p cdce8p commented Aug 26, 2025

The ast ExtSlice and Index classes have been deprecated (and unused) since Python 3.9.
https://docs.python.org/3.9/library/ast.html#ast.AST

@cdce8p cdce8p force-pushed the cleanup-fastparse-nodes branch from b4c3299 to 9338654 Compare August 26, 2025 23:37
@cdce8p cdce8p changed the title Cleanup old ast nodes in fastparse Cleanup old ast classes in fastparse Aug 26, 2025
@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@cdce8p cdce8p requested a review from ilevkivskyi August 27, 2025 00:12
@ilevkivskyi ilevkivskyi merged commit e852829 into python:master Aug 27, 2025
20 checks passed
@cdce8p cdce8p deleted the cleanup-fastparse-nodes branch August 27, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdce8p @ilevkivskyi