enum.auto checking correctness per #3434 #3441
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Normally we always update typeshed in separate PRs. Do you really need to change the typeshed submodule commit in this PR? |
mistermocha
added a commit
to mistermocha/typeshed
that referenced
this pull request
May 24, 2017
Full context: python/mypy#3441
|
This exercises tests that only exercise fixtures. The correctness issue attached here is a test that isn't testing anything at all really. The effective change needed is in the typeshed diff python/typeshed#1331 To that end, I'm withdrawing this diff. |
JelleZijlstra
pushed a commit
to python/typeshed
that referenced
this pull request
May 27, 2017
Full context: python/mypy#3441 Closes python/mypy#3434.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.