Speed up tests by simplifying the stub for typing #3486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't include async types in the default `typing` stub used in tests since it's only needed for a small fraction of test cases. Make it possible to write `[typing fixtures/typing-full.pyi]` in tests to use a more complete complete stub that includes the async types. In the future we can move additional rarely used features to this stub. Also replace the definition of `NewType` in the test fixtures with a simpler one to speed things up slightly. These changes improved the running time of `pytest mypy` by about 35% for me (on macOS).
carljm
added a commit
to carljm/mypy
that referenced
this pull request
Jun 3, 2017
* master: Improve test output when a test doesn't specify the correct fixture (python#3488) Speed up tests by simplifying the stub for typing (python#3486) Clean up test fixtures (python#3485) Add additional quick mode test cases (python#3480) Add --strict-optional on by default to roadmap (python#3478) Minor speed-up in warn-return-any (python#3481)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't include async types in the default
typingstub used in testssince they are only needed for a small fraction of test cases.
Make it possible to write
[typing fixtures/typing-full.pyi]in teststo use a more complete complete stub that includes the async types.
In the future we can move additional rarely used features to this
stub.
Also replace the definition of
NewTypein the test fixtures with asimpler one to speed things up slightly.
These changes improved the running time of
pytest mypyby about 35%for me (on macOS).