Improve test output when a test doesn't specify the correct fixture #3488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve things in two ways: 1) Don't crash in tests due to missing types.ModuleType The fixtures used in many test cases don't import the `types` module to speed up tests, and this would often cause uncaught exceptions while writing tests. Now we generate a useful message instead. 2) Suggest fixtures If a developer is doing certain common things in a mypy test that require a non-default builtins fixture (such as `typing.List`), add a hint that points to a fixture that is likely to help.
carljm
added a commit
to carljm/mypy
that referenced
this pull request
Jun 3, 2017
* master: Improve test output when a test doesn't specify the correct fixture (python#3488) Speed up tests by simplifying the stub for typing (python#3486) Clean up test fixtures (python#3485) Add additional quick mode test cases (python#3480) Add --strict-optional on by default to roadmap (python#3478) Minor speed-up in warn-return-any (python#3481)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve things in two ways:
Don't crash in tests due to missing types.ModuleType
The fixtures used in many test cases don't import the
typesmoduleto speed up tests, and this would often cause uncaught exceptions while
writing tests. Now we generate a useful message instead.
Suggest fixtures
If a developer is doing certain common things in a mypy test that
require a non-default builtins fixture (such as using
typing.List), add ahint that points to a fixture that is likely to help.