fix crash when serializing a type-ignored property setter #3493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the crash from python#3491. I wasn't able to reproduce the crash in a test, even with '# flags: --incremental', so I'm not adding any new tests. Do I need some special flags to make tests write the cache?
|
I think only tests in check-incremental.test and tests whose name ends in 'Incremental' exercise serialization. |
|
So please add such a test. |
Turns out the cache isn't written if there is any error, and I had a reveal_type which counts as an error. The change fixes both bugs from the original issue: - Without --disallow-untyped-defs, it no longer crashes during cache serialization. - With --disallow-untyped-defs, it no longer produces a spurious error because "self" doesn't have an annotation.
|
Thanks, it turns out the issue was that the cache isn't written when there is an error in the file, and I had a reveal_type(), which counts as an error. In other news, it turns out that this PR also fixes the other bug reported in #3491 (the spurious "missing type annotation" error). Therefore, I added tests both with and without |
gvanrossum
reviewed
Jun 3, 2017
| @@ -564,9 +564,10 @@ def analyze_property_with_multi_part_definition(self, defn: OverloadedFuncDef) - | |||
| first_item.var.is_settable_property = True | |||
| # Get abstractness from the original definition. | |||
| item.func.is_abstract = first_item.func.is_abstract | |||
| item.func.accept(self) | |||
| else: | |||
| self.fail("Decorated property not supported", item) | |||
There was a problem hiding this comment.
This should also be fixed (it's in a sense the true reason for the issue). But not in this PR.
gvanrossum
approved these changes
Jun 3, 2017
|
Oh, sorry, I should have copied your updated PR description. Oh well. |
carljm
added a commit
to carljm/mypy
that referenced
this pull request
Jun 3, 2017
* master: fix crash when serializing a type-ignored property setter (python#3493)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two issues from #3491: a crash in serialization and an incorrect error "Function is missing a type annotation for one or more arguments". Both had the same root cause; we were skipping semantic analysis for the function body if mypy was unhappy with the property.setter decorator.