Skip to content

Update pythoneval test according to PR typeshed/#1220 (ABCs -> Protocols) #3846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 19, 2017
Merged

Update pythoneval test according to PR typeshed/#1220 (ABCs -> Protocols) #3846

merged 2 commits into from
Nov 19, 2017

Conversation

ilevkivskyi
Copy link
Member

The test will fail now. This PR contains the tests output after python/typeshed#1220 is merged and synced (note that pythoneval tests are run with full typeshed stubs).

@ilevkivskyi ilevkivskyi mentioned this pull request Aug 19, 2017
Merged
@JukkaL JukkaL added the blocked label Aug 30, 2017
@ilevkivskyi
Copy link
Member Author

The failure is expected, but AppVeyor has crashed in a strange way, this is a second time it happened today on random pushes. @ethanhs do you have any ideas what has happened.

@emmatyping
Copy link
Member

@ilevkivskyi Im taking a look. The error seem non-obvious, but I will try to see if I can figure out what it is.

@elazarg
Copy link
Contributor

elazarg commented Aug 30, 2017

I have encountered similar crash during #3870. IIRC it seemed to happen when multiple instances of pytest were active. It stopped happening after I've changed the PR to use only a single instance. I'm not sure if this information helps though...

@emmatyping emmatyping mentioned this pull request Aug 31, 2017
Closed
@emmatyping
Copy link
Member

Moving to a new issue to not clutter this PR #3895

@gvanrossum gvanrossum changed the title Update pythoneval test according to PR typeshed/#1220 Update pythoneval test according to PR typeshed/#1220 (ABCs -> Protocols) Sep 19, 2017
@gvanrossum
Copy link
Member

I propose to disable this test (by appending -skip to the test name), then merging the typeshed PR, then re-enabling the failing test. That way there's no race between the two PRs. (I find it more stressful to have failing tests than to have a TODO about re-enabling a test.)

@ilevkivskyi ilevkivskyi mentioned this pull request Nov 19, 2017
Merged
@ilevkivskyi ilevkivskyi force-pushed the protocols-typeshed-test branch 2 times, most recently from 6bf65bd to a0d51eb Compare November 19, 2017 09:10
@ilevkivskyi
Copy link
Member Author

@gvanrossum
OK, I temporarily disabled the test. Now this PR re-enables it with the updated output.

@gvanrossum
Copy link
Member

OK, can you rebase/repush this so the tests pass? Then you can merge it.

@ilevkivskyi ilevkivskyi mentioned this pull request Nov 19, 2017
Merged
@ilevkivskyi ilevkivskyi force-pushed the protocols-typeshed-test branch from a0d51eb to c2515f3 Compare November 19, 2017 18:24
@ilevkivskyi
Copy link
Member Author

All tests pass, so I am merging now.

@ilevkivskyi ilevkivskyi merged commit 608b6a6 into python:master Nov 19, 2017
@ilevkivskyi ilevkivskyi deleted the protocols-typeshed-test branch November 19, 2017 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees

@JukkaL JukkaL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ilevkivskyi @emmatyping @elazarg @gvanrossum @JukkaL