Make ClassDef.metaclass an Expression #3848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have another PR #3842 that will have conflicts with this one, which one should be considered first? |
|
This one. #3847 should be easier and cleaner afterwards. Should I close it for now? |
No, it can be left open, but please don't rebase it afterwards, merge master instead. |
|
I will take a look at this later, sorry, don't have time now. |
ilevkivskyi
approved these changes
Aug 30, 2017
|
No time to review but the stated goal seems right and the diff looks simple enough, so no objection to Ivan merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3847.