Format types nicely in incorrectly-returning-Any warning #3910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilevkivskyi
reviewed
Sep 2, 2017
mypy/messages.py
Outdated
| @@ -1005,6 +1004,11 @@ def disallowed_any_type(self, typ: Type, context: Context) -> None: | |||
| message = 'Expression type contains "Any" (has type {})'.format(self.format(typ)) | |||
| self.fail(message, context) | |||
|
|
|||
| def incorrectly_returning_any(self, typ: Type, context: Context) -> None: | |||
| message = 'Returning Any from function with declared return type {}'.format( | |||
There was a problem hiding this comment.
This error might sound awkward in situations like:
Returning Any from function with declared return type <nothing>
Returning Any from function with declared return type overloaded function
Returning Any from function with declared return type Module
I think it will sound better if you say something like
Returning Any from function declared to return <nothing>
Returning Any from function declared to return overloaded function
Returning Any from function declared to return Module
test-data/unit/check-warnings.test
Outdated
| @@ -141,7 +141,7 @@ from typing import Any | |||
| def g() -> Any: pass | |||
| def f() -> int: return g() | |||
| [out] | |||
| main:4: warning: Returning Any from function with declared return type "builtins.int" | |||
| main:4: warning: Returning Any from function with declared return type "int" | |||
There was a problem hiding this comment.
Maybe add one more test for situations where the special formatting takes place (like with callable types and/or long unions and/or NoReturn and/or module type)?
|
@ilevkivskyi Fixed. |
|
(Thanks for the review!) |
ilevkivskyi
approved these changes
Sep 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3899.