Fix type of forward reference to a decorated class method #4486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The case wasn't properly handled before when accessing through a type object -- the type of the forward reference defaulted to `Any`. The fix doesn't work at module top level since module top levels can't be deferred, but the reference would generally fail at runtime anyway. Fixes #4485.
|
This is now ready for review. I've addressed the issues in Dropbox internal code. |
ilevkivskyi
approved these changes
Jan 25, 2018
test-data/unit/check-inference.test
Outdated
| @classmethod | ||
| def h(cls) -> None: | ||
| reveal_type(cls.g) # E: Revealed type is 'def (x: builtins.str)' | ||
| [builtins fixtures/classmethod.pyi] |
There was a problem hiding this comment.
Maybe also add reveal_type(A.g) after the class definition here?
mypy/checkmember.py
Outdated
| return node.node.type | ||
| else: | ||
| not_ready_callback(name, context) | ||
| return AnyType(TypeOfAny.special_form) |
There was a problem hiding this comment.
I thought that we normally return TypeOfAny.from_error in all cases where the may be an error.
carljm
added a commit
to carljm/mypy
that referenced
this pull request
Feb 28, 2018
* master: (27 commits) Don't call --strict-optional and --incremental experimental (python#4642) Sync typeshed (python#4641) Fix callable types with inconsistent argument counts (python#4611) Fix example (add 'class A:') Make psutil an optional dependency (python#4634) mypy and mypy_extensions aren't posix only (python#3765) Documentation for attr support (python#4632) Use read_with_python_encoding in stubgen to handle file encoding (python#3790) Sync typeshed (python#4631) Add remaining core team emails to CREDITS (python#4629) Fix issues with attr code. (python#4628) Better support for converter in attrs plugin. (python#4607) Clean up credits (python#4626) Support type aliases in fine-grained incremental mode (python#4525) Fine-grained: Fix crash caused by unreachable class (python#4613) Treat divmod like a binary operator (python#4585) Sync typeshed (python#4605) Fine-grained: Don't infer partial types from multiple targets (python#4553) Fine-grained: Compare symbol table snapshots when following dependencies (python#4598) Fix type of forward reference to a decorated class method (python#4486) ...
yedpodtrzitko
pushed a commit
to kiwicom/mypy
that referenced
this pull request
Mar 15, 2018
The case wasn't properly handled before when accessing through a type object -- the type of the forward reference defaulted to `Any`. The fix doesn't work at module top level since module top levels can't be deferred, but the reference would generally fail at runtime anyway. Fixes python#4485.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The decorator case wasn't properly handled before when accessing an attribute
through a type object -- the type of the forward reference defaulted to
Any.The fix doesn't work at module top level since module top levels can't
be deferred, but the reference would generally fail at runtime anyway.
Fixes #4485.