Add _cached suffix to test cases in fine-grained tests with cache #4558
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it obvious when a test case fails whether the test case
uses caching or not. Previously both kinds of failures looked similar,
which was confusing.
There is one non-obvious bit: the _cached suffix must be inserted
before other suffixes such as -skip since those suffixes are tested
using endswith(), and it's probably better to have such "effectful"
suffixes at the end so that they are prominent.