Skip to content

Revert "Better support for converter in attrs plugin." #4627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "Better support for converter in attrs plugin." #4627

wants to merge 1 commit into from

Conversation

ilevkivskyi
Copy link
Member

Reverts #4607

@ilevkivskyi
Copy link
Member Author

@euresti If you can fix my comments before the release, this can stay in, otherwise I would revert it (see comments on your original PR).

@euresti
Copy link
Contributor

euresti commented Feb 23, 2018

I'll work on the fixes you want today.

@euresti
Copy link
Contributor

euresti commented Feb 23, 2018

Ok my change is here: #4628

@ilevkivskyi
Copy link
Member Author

Closing in favour of #4628

@ilevkivskyi ilevkivskyi deleted the revert-4607-fix_attr_right branch February 23, 2018 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilevkivskyi @euresti